-
Notifications
You must be signed in to change notification settings - Fork 0
Pagination, image resizing, remove-rating, bug fixes, and test coverage #89
+1,745
−389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Game now displays in correct size even though there is only (max - n) to display #25
bug-fix: Header contrast
New fix made the previous change useless, so I changed it back #25
Rather than just showing a dynamic amount varying on screen size, we now display a fixed amount of 20 games per page. This also suits feedback from user who wanted more games per page. Also a good solution for mobile to save jumping from page to page #25
In cases of text overflow in titles and tags, the text will now truncate #73
Min + max has been set for yearFrom and yearTo inputs, but only works for the arrows! Needs further work...
Changed the score number from "out of 10" to "out of 5" with `score/2` as the showing score. This is to be consistent with the amount of stars. This will hopefully fix the problem with score showing as a date as well #69
Halvor bugfixes
Added array with options for years for the "Year" Select objects in Toolbar.tsx
`yearFrom` and `yearTo` are now changeable via Select object rather than being input objects. `yearTo` only displays valid years (after `yearFrom`). Known bug: when changing `yearFrom` to a year ealier than `yearTo` and applying filter, `yearTo` changes to `Year`, but gives result "No games match these filters."
Implemented a x button that lets a user delete their rating from the gamedetails page.
Average scores now round to nearest 2 decimals when relevant in the UI.
Updated ai-usage.md with info ralating to delivery 2 and 3
Round displayed score to 2 decimals and update AI usage docs
feat: Add remove rating button
Alert with timeout
Changed the way games with missing tags or release year are presented. Now shows "N/A" in grey and italic to emphasize that there are no tags or release year to the game #74
Installed vitest to frontend, and added "test" script
feat: Added text to missing year or tags
Year input fix
Created the setup for and implementation of tests for GameList, Header, Layout, StarRating and Toolbar. Added dev dependencies: @testing-library/react, @testing-library/jest-dom, @testing-library/user-event, jsdom
Extract the page counter and chevron arrows from Toolbar into a shared Pagination component, then reuse it on the My Ratings page so rated games are paged the same way as the main grid.
Image resize, accessibility, and title
test: Add Vitest setup and component tests for Header, Layout, GameListItem, StarRating, and Toolbar
Updatet GameListItem and Header tests to match the updates for delivery 4.
fix: Update Tests to match frontend
Add paging to My Ratings
ayseza
approved these changes
Nov 18, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useIsMobileTest plan
npm run testinfrontend/passes